From 079da1990ef371a53ac0b2769679cc4b35f0b219 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 8 May 2026 12:57:59 +0000
Subject: [PATCH] Apply validation feedback for docs title and workshop
 migration notes

Agent-Logs-Url: https://github.com/GameServerPanel/GSP/sessions/1575c81b-f8a7-433a-8f3b-e068c0992c18

Co-authored-by: iaretechnician <2749183+iaretechnician@users.noreply.github.com>
---
 modules/billing/docs.php                         |  3 ++-
 modules/steam_workshop/agent_update_workshop.php | 11 ++++++-----
 modules/steam_workshop/module.php                |  2 ++
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/modules/billing/docs.php b/modules/billing/docs.php
index 8931e24a..e93301d1 100644
--- a/modules/billing/docs.php
+++ b/modules/billing/docs.php
@@ -20,6 +20,7 @@ $docsDir = __DIR__ . '/docs';
 $action = $_GET['action'] ?? 'list';
 $doc = $_GET['doc'] ?? '';
 $docsPagePath = '/docs.php';
+$pageTitle = $action === 'view' ? 'Documentation' : 'Documentation - GSP';
 
 /**
  * Get all documentation folders with their metadata
@@ -138,7 +139,7 @@ uksort($grouped, function($a, $b) use ($categoryOrder) {
     <meta http-equiv="Cache-Control" content="no-cache, no-store, must-revalidate">
     <meta http-equiv="Pragma" content="no-cache">
     <meta http-equiv="Expires" content="0">
-    <title><?php echo $action === 'view' ? 'Documentation' : 'Documentation - GSP'; ?></title>
+    <title><?php echo htmlspecialchars($pageTitle, ENT_QUOTES, 'UTF-8'); ?></title>
     <link rel="stylesheet" href="css/header.css">
     <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.4.0/css/all.min.css" integrity="sha512-iecdLmaskl7CVkqkXNQ/ZH/XLlvWZOJyj7Yy7tcenmpD1ypASozpmT/E0iPtmFIB46ZmdtAc9eNBvH0H/ZpiBw==" crossorigin="anonymous" referrerpolicy="no-referrer" />
     <style>
diff --git a/modules/steam_workshop/agent_update_workshop.php b/modules/steam_workshop/agent_update_workshop.php
index 46736d66..4c97f5cd 100644
--- a/modules/steam_workshop/agent_update_workshop.php
+++ b/modules/steam_workshop/agent_update_workshop.php
@@ -353,11 +353,12 @@ function sw_agent_steamcmd_download(array $mod, array $profile, array $tpl_vars,
     }
 
     // Validate that steamcmd exists
-    if (!$dry_run && !is_file($steamcmd)) {
-        return array('ok' => false, 'error' => "SteamCMD not found: $steamcmd");
-    }
-    if (!$dry_run && !is_executable($steamcmd)) {
-        return array('ok' => false, 'error' => "SteamCMD is not executable: $steamcmd");
+    if (!$dry_run) {
+        if (!is_file($steamcmd)) {
+            return array('ok' => false, 'error' => "SteamCMD not found: $steamcmd");
+        } elseif (!is_executable($steamcmd)) {
+            return array('ok' => false, 'error' => "SteamCMD is not executable: $steamcmd");
+        }
     }
 
     // Build argument list; escape each argument individually.
diff --git a/modules/steam_workshop/module.php b/modules/steam_workshop/module.php
index ec5fa1a6..d9368a56 100644
--- a/modules/steam_workshop/module.php
+++ b/modules/steam_workshop/module.php
@@ -173,6 +173,8 @@ $install_queries[5] = array(
                       ELSE `schedule_interval`
                     END"
         );
+        // The simplified workflow intentionally hard-disables these legacy fields
+        // for every row so old unsupported behaviors cannot be re-enabled.
         $ok = $ok && (bool)$db->query(
             "UPDATE " . sw_module_table('steam_workshop_server_settings') . "
                 SET `hot_load` = 'disabled', `warning_minutes` = 0"