GSP/Panel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: address review feedback - move JS to script block, use CSS classes

Browse source 
Agent-Logs-Url: https://github.com/GameServerPanel/GSP/sessions/28b4019a-734d-418e-8002-8c1ff0c0f564

Co-authored-by: iaretechnician <2749183+iaretechnician@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-05-03 23:04:03 +00:00 • committed by GitHub
parent 70c3ff8979
commit 21bcdac9d7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 19 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

28
modules/billing/adminserverlist.php
View file

@ -17,6 +17,7 @@
.img-input { width: 160px; } .img-input { width: 160px; }
.img-select { max-width: 180px; } .img-select { max-width: 180px; }
.img-fallback { display: none; max-width: 180px; margin-top: 4px; } .img-fallback { display: none; max-width: 180px; margin-top: 4px; }
.img-fallback.img-fallback-visible { display: block; }
.muted { color: #999; font-size: 0.85em; } .muted { color: #999; font-size: 0.85em; }
.flash-ok { background: #d4edda; border: 1px solid #c3e6cb; padding: 8px 12px; margin-bottom: 10px; border-radius: 4px; color: #155724; } .flash-ok { background: #d4edda; border: 1px solid #c3e6cb; padding: 8px 12px; margin-bottom: 10px; border-radius: 4px; color: #155724; }
.flash-err { background: #f8d7da; border: 1px solid #f5c6cb; padding: 8px 12px; margin-bottom: 10px; border-radius: 4px; color: #721c24; } .flash-err { background: #f8d7da; border: 1px solid #f5c6cb; padding: 8px 12px; margin-bottom: 10px; border-radius: 4px; color: #721c24; }
@ -495,12 +496,8 @@ while ($svcRes && ($row = $svcRes->fetch_assoc())) {
$dropdownVal = (!$isExternal && $savedImg !== '') ? basename($savedImg) : ''; $dropdownVal = (!$isExternal && $savedImg !== '') ? basename($savedImg) : '';
?> ?>
<select name="svc[<?php echo $sid; ?>][img_url]" <select name="svc[<?php echo $sid; ?>][img_url]"
style="max-width:180px;" class="img-select"
onchange=" data-fallback-id="imgfb_<?php echo $sid; ?>">
var other=document.getElementById('imgfb_<?php echo $sid; ?>');
other.style.display=(this.value==='__other__')?'block':'none';
if(this.value!=='__other__') other.value='';
">
<option value="">— none —</option> <option value="">— none —</option>
<?php foreach ($gameImageFiles as $imgFile): ?> <?php foreach ($gameImageFiles as $imgFile): ?>
<option value="<?php echo h($imgFile); ?>" <option value="<?php echo h($imgFile); ?>"
@ -514,14 +511,14 @@ while ($svcRes && ($row = $svcRes->fetch_assoc())) {
</select> </select>
<?php <?php
// Show fallback text input when the saved value is external or not in dropdown // Show fallback text input when the saved value is external or not in dropdown
$fbDisplay = ($isExternal || (!$inDropdown && $savedImg !== '')) ? 'block' : 'none'; $fbClass = ($isExternal || (!$inDropdown && $savedImg !== '')) ? 'img-fallback img-fallback-visible' : 'img-fallback';
$fbValue = ($isExternal || (!$inDropdown && $savedImg !== '')) ? $savedImg : ''; $fbValue = ($isExternal || (!$inDropdown && $savedImg !== '')) ? $savedImg : '';
?> ?>
<input type="text" <input type="text"
id="imgfb_<?php echo $sid; ?>" id="imgfb_<?php echo $sid; ?>"
class="<?php echo $fbClass; ?>"
name="svc[<?php echo $sid; ?>][img_url_other]" name="svc[<?php echo $sid; ?>][img_url_other]"
placeholder="Full URL or filename" placeholder="Full URL or filename"
style="display:<?php echo $fbDisplay; ?>;max-width:180px;margin-top:4px;"
value="<?php echo h($fbValue); ?>"> value="<?php echo h($fbValue); ?>">
</td> </td>
@ -576,5 +573,18 @@ while ($svcRes && ($row = $svcRes->fetch_assoc())) {
</div> </div>
<?php billing_maybe_close_db($db); ?> <?php billing_maybe_close_db($db); ?>
<script>
// Toggle fallback text input when image dropdown changes
document.querySelectorAll('select[data-fallback-id]').forEach(function (sel) {
sel.addEventListener('change', function () {
var fb = document.getElementById(this.dataset.fallbackId);
if (!fb) return;
var show = (this.value === '__other__');
fb.classList.toggle('img-fallback-visible', show);
if (!show) fb.value = '';
});
});
</script>
</body> </body>
</html> </html>