From 2c1f87b54a17ef46c34a41650d261f2c389eb074 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Tue, 5 May 2026 19:09:23 +0000
Subject: [PATCH] =?UTF-8?q?fix:=20address=20code=20review=20feedback=20?=
 =?UTF-8?q?=E2=80=94=20setStatus=20always=20defined,=20prepared=20stmt=20i?=
 =?UTF-8?q?n=20checkout=5Ffree,=20better=20DB=20error=20message?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Agent-Logs-Url: https://github.com/GameServerPanel/GSP/sessions/d18a8f6c-0715-46c4-9c97-94ec7e2a22fc

Co-authored-by: iaretechnician <2749183+iaretechnician@users.noreply.github.com>
---
 modules/billing/cart.php          | 12 ++++++++----
 modules/billing/checkout_free.php | 23 +++++++++++++----------
 2 files changed, 21 insertions(+), 14 deletions(-)

diff --git a/modules/billing/cart.php b/modules/billing/cart.php
index 18024d5c..1483423a 100644
--- a/modules/billing/cart.php
+++ b/modules/billing/cart.php
@@ -655,14 +655,18 @@ $siteBase = $protocol . $host;
             </div>
             <?php endif; ?>
 
-            <?php if ($final_amount > 0.00): ?>
             <script>
                 function setStatus(msg) {
                     const statusDiv = document.getElementById('status-message');
-                    statusDiv.textContent = msg;
-                    statusDiv.style.display = 'block';
+                    if (statusDiv) {
+                        statusDiv.textContent = msg;
+                        statusDiv.style.display = 'block';
+                    }
                 }
+            </script>
 
+            <?php if ($final_amount > 0.00): ?>
+            <script>
                 paypal.Buttons({
                     createOrder: function(data, actions) {
                         setStatus('Creating order...');
@@ -740,7 +744,7 @@ $siteBase = $protocol . $host;
                     // Remove invoice via AJAX and perform a partial reload of the cart container
                     function removeInvoice(invoiceId) {
                         if (!confirm('Remove this item from your cart?')) return;
-                        if (typeof setStatus === 'function') setStatus('Removing item...');
+                        setStatus('Removing item...');
 
                         var body = 'remove_invoice_ajax=1&invoice_id=' + encodeURIComponent(invoiceId);
 
diff --git a/modules/billing/checkout_free.php b/modules/billing/checkout_free.php
index 08899262..da0af1b7 100644
--- a/modules/billing/checkout_free.php
+++ b/modules/billing/checkout_free.php
@@ -32,22 +32,25 @@ if ($_SERVER['REQUEST_METHOD'] !== 'POST') {
 // DB connection
 $db = mysqli_connect($db_host, $db_user, $db_pass, $db_name, isset($db_port) ? (int)$db_port : null);
 if (!$db) {
-    die('Database connection failed: ' . htmlspecialchars(mysqli_connect_error()));
+    die('<p>Database connection failed. Please <a href="/order.php">return to the shop</a> or contact support.</p>');
 }
 mysqli_set_charset($db, 'utf8mb4');
 
-// Fetch unpaid invoices for this user
+// Fetch unpaid invoices for this user (prepared statement)
 $invoices = [];
-$q = mysqli_query($db, "SELECT * FROM {$table_prefix}billing_invoices
-                        WHERE user_id = " . intval($userId) . "
-                          AND (status = 'due' OR status = '')
-                          AND (payment_status IS NULL OR payment_status NOT IN ('paid','cancelled','refunded'))
-                        ORDER BY invoice_id ASC");
-if ($q) {
-    while ($row = mysqli_fetch_assoc($q)) {
+$stmt = mysqli_prepare($db, "SELECT * FROM {$table_prefix}billing_invoices
+                             WHERE user_id = ?
+                               AND (status = 'due' OR status = '')
+                               AND (payment_status IS NULL OR payment_status NOT IN ('paid','cancelled','refunded'))
+                             ORDER BY invoice_id ASC");
+if ($stmt) {
+    mysqli_stmt_bind_param($stmt, 'i', $userId);
+    mysqli_stmt_execute($stmt);
+    $result = mysqli_stmt_get_result($stmt);
+    while ($row = mysqli_fetch_assoc($result)) {
         $invoices[] = $row;
     }
-    mysqli_free_result($q);
+    mysqli_stmt_close($stmt);
 }
 
 if (empty($invoices)) {