From c737f0caa70e485e1695a7e288acb81141734208 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Mon, 4 May 2026 11:40:45 +0000
Subject: [PATCH] fix: remove debug output, Steam Workshop menu item, and PHP
 8.3 TypeErrors in admin controller

Agent-Logs-Url: https://github.com/GameServerPanel/GSP/sessions/b402e67e-690f-4d0c-be37-181af3833298

Co-authored-by: iaretechnician <2749183+iaretechnician@users.noreply.github.com>
---
 modules/gamemanager/server_monitor.php         |  1 -
 .../controllers/AdminWorkshopController.php    | 18 +++++++++---------
 modules/steam_workshop/module.php              |  8 +-------
 3 files changed, 10 insertions(+), 17 deletions(-)

diff --git a/modules/gamemanager/server_monitor.php b/modules/gamemanager/server_monitor.php
index 9d14dfdd..0369906b 100644
--- a/modules/gamemanager/server_monitor.php
+++ b/modules/gamemanager/server_monitor.php
@@ -594,7 +594,6 @@ echo "<table id='servermonitor' class='tablesorter' data-sortlist='[[0,0],[3,1]]
 		 "' data-upload_failure='". get_lang("check_dev_console") .
 		 "' >put the log file here</div>\n";
 */
-echo "<div>Put the log file here</div>";
 //include("log.php");
 ?>
 
diff --git a/modules/steam_workshop/controllers/AdminWorkshopController.php b/modules/steam_workshop/controllers/AdminWorkshopController.php
index d4110602..f66ebb44 100644
--- a/modules/steam_workshop/controllers/AdminWorkshopController.php
+++ b/modules/steam_workshop/controllers/AdminWorkshopController.php
@@ -148,8 +148,8 @@ class AdminWorkshopController
     {
         $rows = [];
         foreach ($this->gameGroups as $group) {
-            $primaryKey = $group['primary_game_key'];
-            $override = ($this->adapterFormGameKey === $primaryKey) ? $this->adapterFormOverride : null;
+            $primaryKey = isset($group['primary_game_key']) ? (string)$group['primary_game_key'] : '';
+            $override = ($primaryKey !== '' && $this->adapterFormGameKey === $primaryKey) ? $this->adapterFormOverride : null;
 
             $mappingValues = [];
             foreach ((array)$group['game_keys'] as $gameKey) {
@@ -159,16 +159,16 @@ class AdminWorkshopController
             }
 
             $rows[] = [
-                'group_key' => $group['group_key'],
-                'app_id' => $group['app_id'],
-                'game_name' => $group['game_name'],
-                'game_keys' => $group['game_keys'],
+                'group_key' => $group['group_key'] ?? '',
+                'app_id' => $group['app_id'] ?? '',
+                'game_name' => $group['game_name'] ?? '',
+                'game_keys' => $group['game_keys'] ?? [],
                 'primary_game_key' => $primaryKey,
                 'mixed_mapping' => count((array)$mappingValues) > 1,
                 'selected_adapter' => count((array)$mappingValues) === 1 ? array_key_first($mappingValues) : '',
-                'exists' => $this->service->gameAdapterExists($primaryKey),
-                'adapter' => $this->service->getGameAdapter($primaryKey),
-                'updated_at' => $this->service->getGameAdapterUpdatedAt($primaryKey),
+                'exists' => $primaryKey !== '' && $this->service->gameAdapterExists($primaryKey),
+                'adapter' => $primaryKey !== '' ? $this->service->getGameAdapter($primaryKey) : null,
+                'updated_at' => $primaryKey !== '' ? $this->service->getGameAdapterUpdatedAt($primaryKey) : null,
                 'form' => $this->service->getAdapterFormData($primaryKey, $override),
             ];
         }
diff --git a/modules/steam_workshop/module.php b/modules/steam_workshop/module.php
index 1a0aaeed..715a5cec 100644
--- a/modules/steam_workshop/module.php
+++ b/modules/steam_workshop/module.php
@@ -26,13 +26,7 @@ $module_title = "Steam Workshop";
 $module_version = "2.1";
 $db_version = 1;
 $module_required = TRUE;
-$module_menus = array(
-	array(
-		'subpage' => 'workshop_admin',
-		'name'    => 'Steam Workshop',
-		'group'   => 'admin'
-	)
-);
+$module_menus = array();
 
 // Database schema migration: create the three Workshop tables when not present.
 // Called by the panel module installer when db_version increments.