From 72a06383e0208450e19ec366ec1d8efa26c25b74 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Wed, 6 May 2026 23:01:33 +0000
Subject: [PATCH] Polish readability issues from validation feedback

Agent-Logs-Url: https://github.com/GameServerPanel/GSP/sessions/b16096ca-4ef7-4bb0-80e8-658767561478

Co-authored-by: iaretechnician <2749183+iaretechnician@users.noreply.github.com>
---
 modules/config_games/config_servers.php       | 8 +++++---
 modules/steam_workshop/admin.php              | 5 ++++-
 modules/steam_workshop/includes/functions.php | 7 +++----
 3 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/modules/config_games/config_servers.php b/modules/config_games/config_servers.php
index df82806b..a2ae3260 100644
--- a/modules/config_games/config_servers.php
+++ b/modules/config_games/config_servers.php
@@ -465,7 +465,10 @@ function config_games_parse_section_payload($sectionName, $sectionXml)
     libxml_clear_errors();
     libxml_use_internal_errors($prev);
     if (!$ok) {
-        $msg = !empty($errors) ? trim($errors[0]->message) . ' (line ' . $errors[0]->line . ')' : 'Section XML is not well-formed.';
+        $msg = 'Section XML is not well-formed.';
+        if (!empty($errors)) {
+            $msg = trim($errors[0]->message) . ' (line ' . $errors[0]->line . ')';
+        }
         return array(false, $msg);
     }
 
@@ -688,8 +691,7 @@ function config_games_render_top_level_editor($home_cfg_id, $configFile)
     }
 
     echo "<h3>Section Editor</h3>";
-    $sectionEditorNote = "Edit one top-level section at a time. Validate a block before saving. "
-        . "Required sections cannot be removed. Optional sections can be added or removed safely.";
+    $sectionEditorNote = "Edit one top-level section at a time. Validate a block before saving. Required sections cannot be removed. Optional sections can be added or removed safely.";
     echo "<p class='note'>{$sectionEditorNote}</p>";
 
     if (!empty($optionalMissing)) {
diff --git a/modules/steam_workshop/admin.php b/modules/steam_workshop/admin.php
index 84a8fafb..09977c00 100644
--- a/modules/steam_workshop/admin.php
+++ b/modules/steam_workshop/admin.php
@@ -62,7 +62,10 @@ function exec_ogp_module()
         $overwrite = isset($_POST['overwrite_existing']) && $_POST['overwrite_existing'] === '1';
         $updated = sw_apply_detected_profile_defaults($db, $profile, $detected, $overwrite);
         if ($updated > 0) {
-            sw_success("Applied $updated detected default value(s)." . ($overwrite ? ' Existing values were allowed to be overwritten.' : ' Existing non-empty values were kept.'));
+            $overwriteMessage = $overwrite
+                ? ' Existing values were allowed to be overwritten.'
+                : ' Existing non-empty values were kept.';
+            sw_success("Applied $updated detected default value(s)." . $overwriteMessage);
         } else {
             sw_success('No profile values needed updating based on current overwrite setting.');
         }
diff --git a/modules/steam_workshop/includes/functions.php b/modules/steam_workshop/includes/functions.php
index 7e25e271..6261f444 100644
--- a/modules/steam_workshop/includes/functions.php
+++ b/modules/steam_workshop/includes/functions.php
@@ -267,11 +267,10 @@ function sw_sync_profiles($db)
 
         $safe_config = $db->realEscapeSingle($config_name);
         $safe_name   = $db->realEscapeSingle($game_name);
+        $insertSql = "INSERT IGNORE INTO " . sw_table('steam_workshop_game_profiles') .
+            " (`config_name`, `game_name`, `enabled`) VALUES ('$safe_config', '$safe_name', 0)";
 
-        $ok = $db->query(
-            "INSERT IGNORE INTO " . sw_table('steam_workshop_game_profiles') .
-            " (`config_name`, `game_name`, `enabled`) VALUES ('$safe_config', '$safe_name', 0)"
-        );
+        $ok = $db->query($insertSql);
         if ($ok) {
             $created++;
         }