GSP/Panel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: address code review feedback (comment clarity, remove redundant static array, add CSS class)

Browse source 
Agent-Logs-Url: https://github.com/GameServerPanel/GSP/sessions/86bb1e0e-2bbd-439b-88cd-7a624ad24761

Co-authored-by: iaretechnician <2749183+iaretechnician@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-05-04 00:13:49 +00:00 • committed by GitHub
parent 5c463d381f
commit d0c86926bd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 2 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
home.php
View file

@ -234,7 +234,7 @@ function ogpHome()
if ($isAdmin) {
$xml_errors = function_exists('gsp_get_xml_errors') ? gsp_get_xml_errors() : array();
if (!empty($xml_errors)) {
echo "<div style='background:#fff3cd;border:1px solid #ffc107;border-radius:4px;padding:10px 14px;margin:10px 0;color:#856404;font-size:0.9em;'>";
echo "<div class='gsp-xml-error-banner' style='background:#fff3cd;border:1px solid #ffc107;border-radius:4px;padding:10px 14px;margin:10px 0;color:#856404;font-size:0.9em;'>";
echo "<strong>⚠ One or more game config XML files failed to load and have been skipped:</strong><ul style='margin:6px 0 0 16px;'>";
foreach ($xml_errors as $xe) {
echo "<li><code>" . htmlspecialchars(basename($xe['file']), ENT_QUOTES, 'UTF-8') . "</code>: "

8
modules/config_games/server_config_parser.php
View file

@ -63,14 +63,6 @@ if (!function_exists('gsp_collect_xml_error')) {
$log_message = "[GSP] $title" . (empty($details) ? '' : ' Details: ' . $details);
error_log($log_message);
static $errors = [];
$errors[] = array(
'file' => $file,
'title' => $title,
'details' => $details,
);
// Store in a predictable global so callers (e.g. home.php) can read it
// even across include boundaries without having to call the function.
$GLOBALS['_gsp_xml_errors'][] = array(
'file' => $file,
'title' => $title,

1
modules/faq/rss_php.php
View file

@ -76,6 +76,7 @@ class rss_php {
$rss = ltrim($rss);
// Reject obviously non-XML content early to avoid noisy libxml warnings.
// Minimum well-formed XML is at least "<a/>" (4 bytes); require one more.
if(strlen($rss) < 5 || $rss[0] !== '<') {
return;
}