GSP/Panel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(steam_workshop): address code review feedback

Browse source 
- WorkshopInstaller: rename cachePath/installPath params to sourcePath/targetPath in checkNeedsSync; replace account_placeholder with TODO comment explaining feature is pending
- WorkshopRepository: remove duplicate docblock on insertOrUpdateMod
- module.php: improve install_queries version comments
- user_workshop_mods.php: rename $scriptPath to $requestPath
- profile_form.php: add symlink limitation note to copy method dropdown
- lang/en_US.php: update steamcmd login mode hint to reflect account mode status"

Agent-Logs-Url: https://github.com/GameServerPanel/GSP/sessions/e7f0d80d-f775-4794-adbd-cf48b55bc9c1

Co-authored-by: iaretechnician <2749183+iaretechnician@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-05-04 19:52:22 +00:00 • committed by GitHub
parent 69f415ad86
commit df4f1d1bdc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 20 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

2
modules/steam_workshop/views/admin/profile_form.php
View file

@ -20,7 +20,7 @@ $folderFormats = ['@%mod_name%' => '@%mod_name% (mod title)', '@%workshop_id%'
$curFolderFormat = (string)($profile['folder_naming_format'] ?? '@%workshop_id%');
$separatorList = ['semicolon' => 'Semicolon ( ; )', 'comma' => 'Comma ( , )', 'space' => 'Space ( )'];
$curSeparator = (string)($profile['mod_separator'] ?? 'semicolon');
$copyMethods = ['rsync' => 'rsync (Linux/Unix)', 'copy' => 'cp / basic copy', 'symlink' => 'Symlink'];
$copyMethods = ['rsync' => 'rsync (Linux/Unix)', 'copy' => 'cp / basic copy', 'symlink' => 'Symlink (requires persistent cache path)'];
$curCopyMethod = (string)($profile['copy_method'] ?? 'rsync');
$loginModes = ['anonymous' => 'Anonymous (recommended for free mods)', 'account' => 'Configured account (paid games)'];
$curLoginMode = (string)($profile['steamcmd_login_mode'] ?? 'anonymous');

4
modules/steam_workshop/views/user_workshop_mods.php
View file

@ -287,8 +287,8 @@ $statusClass = match($lastStatus) {
<!-- ── Steam Workshop search widget ── -->
<?php
$scriptPath = (string)($_SERVER['PHP_SELF'] ?? '/index.php');
$searchEndpoint = sprintf('%s?m=steam_workshop&p=main&action=search&home_id=%d', $scriptPath, $homeId);
$requestPath = (string)($_SERVER['PHP_SELF'] ?? '/index.php');
$searchEndpoint = sprintf('%s?m=steam_workshop&p=main&action=search&home_id=%d', $requestPath, $homeId);
$langAttrs = [
'add' => $lang['mod_picker_action_add'] ?? 'Add',
'remove' => $lang['mod_picker_action_remove'] ?? 'Remove',