fix: declare FormTable::$i property and consolidate created_by_admin into INSERT

Agent-Logs-Url: https://github.com/GameServerPanel/GSP/sessions/f945ff87-7135-4e6f-bbdb-f3ec276ac89b

Co-authored-by: iaretechnician <2749183+iaretechnician@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-05-01 13:28:02 +00:00 committed by GitHub
parent 674fd1ce21
commit facd1f0269
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 13 deletions

View file

@ -60,11 +60,7 @@
class FormTable {
public function __construct()
{
$this->i = 0;
}
public $i = 0;
public function start_form($action, $method = "post", $extra = "")
{

View file

@ -5,7 +5,7 @@
* Shared helper for recording admin-created game servers in the billing tables,
* so they are treated identically to FREE website orders:
* billing_invoices (status='paid', amount=0)
* billing_orders (status='installed', price=0, created_by_admin=1)
* billing_orders (status='installed', price=0, created_by_admin=1, set in INSERT)
*
* This does NOT re-provision the server the caller (add_home.php) already
* created the server via the panel DB layer. We only write the billing ledger
@ -134,6 +134,7 @@ if (!function_exists('admin_register_server_in_billing')) {
'payment_txid' => 'admin-created',
'paid_ts' => $now,
'coupon_id' => 0,
'created_by_admin' => 1,
);
$order_id = $db->resultInsertId('billing_orders', $order_fields);
@ -141,13 +142,6 @@ if (!function_exists('admin_register_server_in_billing')) {
return FALSE;
}
// Optionally mark as admin-created (column added by admin_billing_migration.sql)
$db->query(
"UPDATE OGP_DB_PREFIXbilling_orders
SET created_by_admin = 1
WHERE order_id = " . intval($order_id)
);
// ------------------------------------------------------------------ //
// 5. Link the invoice back to the new order. //
// ------------------------------------------------------------------ //